feat(protocol): Remove non-working FoundryRandom and implement a custom one #13651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FoundryRandom's codebase does not provide us with random variables. (Maybe it's on my machine ((!?)).
You can test it out by putting this debug logging into the current code you have at
major_protocol_upgrade_alpha3
's TaikoL1.sim.sol file: (somewhere after the random generation of the respective variables):This branch and PR are solving the problem with a custom randomGenerator with randomNum+salt. (Obviously semi-random, but seems to be working.)