-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-ui): handle scientific notation #14105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14105 +/- ##
==========================================
+ Coverage 51.57% 51.62% +0.04%
==========================================
Files 148 149 +1
Lines 3874 3878 +4
Branches 336 336
==========================================
+ Hits 1998 2002 +4
Misses 1765 1765
Partials 111 111
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jscriptcoder
requested review from
KorbinianK,
dionysuzx,
adaki2004,
dantaik,
davidtaikocha and
cyberhorsey
July 5, 2023 08:33
davidtaikocha
previously approved these changes
Jul 5, 2023
dantaik
approved these changes
Jul 5, 2023
davidtaikocha
approved these changes
Jul 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Relayer might return e-notation ints such as
2e+21
.BigNumber
cannot handle this formatSolution: using built-in
BigInt
to help us handle itNote: Bridge-UI v2 is no longer using BigNumber library. will be using built-in
bigint
instead 😉