Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): enable strike price to token grants #15522

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 18, 2024

Minimal change to add strike price support to TimelockTokenPool. All tests are migrated from Dani's PR #15506

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Jan 18, 2024 3:05pm

@dantaik dantaik added this pull request to the merge queue Jan 19, 2024
Merged via the queue into alpha-6 with commit baefaef Jan 19, 2024
14 checks passed
@dantaik dantaik deleted the strike-price branch January 19, 2024 09:03
@adaki2004
Copy link
Contributor

adaki2004 commented Jan 19, 2024

@dantaik One question to the concept with an example - if i understand it well. Let's say:

  1. Alice gets a grant 1, with a strike price 0.1 USD/token, e.g.: 100 tokens.
  2. Alice gets a grant 2, with a strike price 1.5 USD/token, eg.: 50 token again.
  3. Later, when Alice's tokens are unlocked, she is about to withdraw tokens -> but the token price e.g.: is 0.4.

In this design there is no way for Alice to refuse (or not withdraw) grant 2, and pay for just grant 1 - because all happens in the same transaction so basically all or nothing. And in this case Alice would pay 10 + 75 = 85 for 200 tokens, which worth 80 on the market. Isn't it a possible scenario ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants