feat(protocol): safeguard possible failing calls #16931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaki2004
requested review from
Brechtpd,
dantaik and
davidtaikocha
and removed request for
dantaik
dantaik
reviewed
Apr 30, 2024
feat(protocol): safeguard possible failing calls
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dantaik
reviewed
Apr 30, 2024
dantaik
approved these changes
Apr 30, 2024
davidtaikocha
approved these changes
Apr 30, 2024
Brechtpd
approved these changes
Apr 30, 2024
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
davidtaikocha
approved these changes
Apr 30, 2024
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you agree, also still not merge it ! We can practice the upgrades on mainnet with this tiny one.