Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): remove bridged token impl dependencies from vaults #17067

Merged
merged 14 commits into from
May 10, 2024
Merged

refactor(protocol): remove bridged token impl dependencies from vaults #17067

merged 14 commits into from
May 10, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented May 9, 2024 •
edited
Loading

With a few new interfaces, vaults no longer depend on any bridged token implementation but their interfaces, which will be helpful to avoid mistakes like cfc8fa8

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented May 9, 2024 •
edited
Loading

refactor(protocol): remove bridged token impl dependencies from vaults

Generated at commit: 29735b0e63aa11c237c1467d37bbac53582c95c8

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
6
41
51
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik marked this pull request as ready for review May 9, 2024 17:18
@dantaik dantaik requested review from davidtaikocha, adaki2004 and Brechtpd and removed request for davidtaikocha May 9, 2024 17:18
@dantaik dantaik changed the title refactor(protocol): defines interfaces for bridged NFT tokens refactor(protocol): remove bridged token impl dependencies from vaults May 9, 2024
Base automatically changed from revert_batch to main May 9, 2024 17:38
@dantaik dantaik marked this pull request as draft May 10, 2024 01:39
@dantaik dantaik marked this pull request as ready for review May 10, 2024 01:55
@dantaik dantaik enabled auto-merge May 10, 2024 02:04
@dantaik dantaik added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 13ad99d May 10, 2024
4 checks passed
@dantaik dantaik deleted the bridged_iface branch May 10, 2024 06:08
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @Brechtpd @davidtaikocha