Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for ontake upgrade #27

Merged
merged 10 commits into from
Aug 16, 2024
Merged

Conversation

smtmfft
Copy link

@smtmfft smtmfft commented Jul 25, 2024

No description provided.

@smtmfft smtmfft marked this pull request as draft July 25, 2024 09:06
@smtmfft smtmfft force-pushed the v1.0.0-rc.2-taiko-ontake branch 3 times, most recently from d02e77e to e2baa29 Compare July 25, 2024 09:22
Signed-off-by: smtmfft <smtm@taiko.xyz>
@smtmfft smtmfft force-pushed the v1.0.0-rc.2-taiko-ontake branch 2 times, most recently from c953ae8 to c0c465b Compare July 31, 2024 09:30
@smtmfft smtmfft marked this pull request as ready for review August 10, 2024 04:58
Copy link

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think best to revert formatting changes to non-taiko specific code, otherwise more potential merge work in the future and also bigger diff to go through.

crates/ethereum-forks/src/hardfork.rs Outdated Show resolved Hide resolved
@smtmfft
Copy link
Author

smtmfft commented Aug 15, 2024

I think best to revert formatting changes to non-taiko specific code, otherwise more potential merge work in the future and also bigger diff to go through.

reverted, now only feature related code in PR, through a little bit frustrating that can not use auto fmt :)

@smtmfft smtmfft requested a review from Brechtpd August 16, 2024 05:09
@smtmfft smtmfft merged commit 910b6f1 into v1.0.0-rc.2-taiko Aug 16, 2024
5 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants