Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GRPC support (WIP) #551

Closed
wants to merge 1 commit into from
Closed

feat: add GRPC support (WIP) #551

wants to merge 1 commit into from

Conversation

thaodt
Copy link

@thaodt thaodt commented Oct 29, 2023 •
edited
Loading

Summary:
This PR is served for adding gRPC support next to http (the current available data-source only).
What's inside this PR:

  • build custom parser to convert GraphQL schema into protobuf.
  • generate Rust data types from this proto and use tonic-reflection to dynamically discover services at runtime.
  • maintain strong typing and service contracts, and enables clients to discover available gRPC services without needing to recompile when services change.
  • this also means adding grpc directive.
  • tests needs to be covered all possible cases.

Issue Reference(s):
New feature #414

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

@github-actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 2 days.

@github-actions github-actions bot added the Stale label Oct 31, 2023
@thaodt thaodt force-pushed the feat/grpc-support branch from b508ffd to 3bc800e Compare October 31, 2023 04:12
@github-actions github-actions bot removed the Stale label Oct 31, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Action required: PR inactive for 2 days.
Status update or closure in 2 days.

@github-actions github-actions bot added the Stale label Nov 2, 2023
@thaodt thaodt force-pushed the feat/grpc-support branch from 3bc800e to 75f66f7 Compare November 2, 2023 14:13
@github-actions github-actions bot removed the Stale label Nov 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Action required: PR inactive for 2 days.
Status update or closure in 2 days.

@github-actions github-actions bot added the Stale label Nov 4, 2023
@github-actions github-actions bot removed the Stale label Nov 5, 2023
@thaodt thaodt force-pushed the feat/grpc-support branch from 11394e0 to bbe1c52 Compare November 6, 2023 05:52
@thaodt thaodt force-pushed the feat/grpc-support branch from bbe1c52 to 81fef8b Compare November 7, 2023 07:30
@github-actions GitHub Actions
Copy link

Action required: PR inactive for 2 days.
Status update or closure in 2 days.

@github-actions github-actions bot added the Stale label Nov 10, 2023
@github-actions GitHub Actions
Copy link

PR closed after 2 days of inactivity.

@github-actions github-actions bot closed this Nov 12, 2023
@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thaodt