-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: npm publish issue with glib #633
fix: npm publish issue with glib #633
Conversation
This might get problematic as support for We'll also have to account for third party package managers like yarn and pnpm |
I know that yarn, pnpm and bun already supports, but I didn't knew about the version restriction on NPM. maybe we should close this @meskill? |
there is already npm@10 and the v9 is shipped with the node18 that soon will enter maintence stage. So, we could actually just support those active versions for npm and probably for other package managers as well. I suggest also to take a look into swc repo and issues and search for any issues they have with libc field as I saw they are using this approach |
b6ff97b
to
300634d
Compare
Summary:
Replacing post-install script by libc field on
package.json
(which is handled automatically by Node.js)Issue Reference(s):
Fixes #628
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist: