Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to 2018 edition #11

Merged
merged 3 commits into from
Jan 18, 2020
Merged

Migrate to 2018 edition #11

merged 3 commits into from
Jan 18, 2020

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Jan 17, 2020 •
edited
Loading

  • Migrate to 2018 edition
  • Fix some clippy warnings

@koushiro koushiro requested a review from tailhook January 17, 2020 08:35
@koushiro
Copy link
Contributor Author

BTW, how about migrating to 2018 edition?

@tailhook
Copy link
Owner

I'm okay with migrating to edition 2018. But rustfmt.... Here is my comment on previous PR doing this: #9 (comment). I also prefer max_width=80 it's more comfortable side-by-side editing and also for reviewing diffs on github.

@koushiro
Migrate to 2018 edition
897b7f6 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Fix clippy warnings
2ec4fba 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro koushiro changed the title Apply rustfmt and clippy Migrate to 2018 edition Jan 17, 2020
@koushiro
Copy link
Contributor Author

@tailhook PTAL again :)

tailhook
tailhook reviewed Jan 17, 2020
View reviewed changes
Copy link
Owner

@tailhook tailhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except few tiny things.

src/lib.rs Outdated Show resolved Hide resolved
src/duration.rs Outdated Show resolved Hide resolved
src/date.rs Outdated Show resolved Hide resolved
@koushiro
Apply suggestions
f00dbba 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro koushiro requested a review from tailhook January 18, 2020 03:47
@tailhook tailhook merged commit 4a40682 into tailhook:master Jan 18, 2020
@tailhook
Copy link
Owner

Looks nice. Thank you!

@tailhook
Copy link
Owner

By the way, env_logger which depends on this, has MSRV 1.31. Is there anything that requires 1.32?

@tailhook
Copy link
Owner

Hm, it seems self:: is required on 1.31, and also tests don't work.

@koushiro
Copy link
Contributor Author

At first, I just raised MSRV to 1.32 in order to use rand 0.7 in the test. Now it seems that we must add self:: 😆

@koushiro koushiro deleted the apply-rustfmt-and-clippy branch January 18, 2020 14:57
@Bond-009 Bond-009 mentioned this pull request Dec 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tailhook tailhook Awaiting requested review from tailhook

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koushiro @tailhook