Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Explorer: ~ not expanded in "Change root directory" dialog #200

Closed
thisisparker opened this issue Aug 15, 2023 · 0 comments · Fixed by #230
Closed

Node Explorer: ~ not expanded in "Change root directory" dialog #200

thisisparker opened this issue Aug 15, 2023 · 0 comments · Fixed by #230
Assignees
@tendstofortytwo
Labels
good first issue Good for newcomers

Comments

@thisisparker
Copy link
Contributor

When customizing the root directory of a connected node, I expect to be able to use ~. Currently, attempting to save paths that use ~ produces the error e.g. ~/src is an invalid absolute path
@samlinville samlinville added the good first issue Good for newcomers label Sep 19, 2023
@tendstofortytwo tendstofortytwo mentioned this issue Sep 19, 2023
Merged
tendstofortytwo added a commit that referenced this issue Sep 21, 2023
@tendstofortytwo
Node Explorer: accept subdirectories of ~ for root directory (#230)
51b4042 
Fixes #200.

---------

Signed-off-by: Naman Sood <mail@nsood.in>
tylersmalley pushed a commit that referenced this issue Sep 28, 2023
@tendstofortytwo
Node Explorer: accept subdirectories of ~ for root directory (#230)
7525af7 
Fixes #200.

---------

Signed-off-by: Naman Sood <mail@nsood.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tendstofortytwo tendstofortytwo

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Node Explorer: accept subdirectories of ~ for root directory tailscale-dev/vscode-tailscale
3 participants
@thisisparker @samlinville @tendstofortytwo