Skip to content

Conversation

@jakubmeysner
Copy link
Contributor

@jakubmeysner jakubmeysner commented Apr 20, 2025

Displays exit node status (including the name of the exit node) in the permanent connection notification's content (moving the overall connected/disconnected status to the title).

Fixes tailscale/tailscale#14438

Using exit node Not using exit node Disconnected
Connected using exit node permanent notification Connected permanent notification Disconnected notification

Could potentially also be extended to modify the notification icon similarly to desktop - however I do not have access to that asset, and it'd probably require some modification to fit within the safe display area.

Connected using exit node tray icon on desktop

Also includes formatting of existing code using ktfmt (ktfmtFormat Gradle task) and a fix for an invalid instruction in the Dockerfile causing build failures.

Signed-off-by: Jakub Meysner <git@jakubmeysner.com>
@ghost
Copy link

ghost commented Apr 20, 2025

Pull Request Revisions

RevisionDescription
r2
Refactored notification and exit node logicAdded distinctUntilChanged() to flow, created helper method showForegroundNotification(), and improved exit node name retrieval logic
r1
Added exit node name to notificationsModified notification generation to include the name of the active exit node when one is selected, enhancing the status notification with more contextual information about the current VPN connection.
✅ AI review completed for r2
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

…ation

Displays exit node status (including the name of the exit node) in the permanent connection notification's content (moving the overall connected/disconnected status to the title).

Fixes tailscale/tailscale#14438

Signed-off-by: Jakub Meysner <git@jakubmeysner.com>
…h for files destination directory

> If the source is a file, and the destination doesn't end with a trailing slash, the source file will be written to the destination path as a file.
~ https://docs.docker.com/reference/dockerfile/#destination

Signed-off-by: Jakub Meysner <git@jakubmeysner.com>
@jakubmeysner jakubmeysner force-pushed the feature/#14438-display-exit-node-information-in-permanent-notification branch from f642bde to af44e1e Compare April 20, 2025 22:11
@jakubmeysner
Copy link
Contributor Author

jakubmeysner commented Apr 25, 2025

Hi @kari-ts and @nickoneill, sorry about the mention(s), but could you please take a look at this PR when you have a chance?

@kari-ts kari-ts self-requested a review April 26, 2025 01:15
Copy link
Collaborator

@kari-ts kari-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kari-ts kari-ts merged commit 8683c78 into tailscale:main Apr 26, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Display exit node information in permanent notification (Android)

2 participants