Feature/550 lambda eventsourcemapping #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VedankPande
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
Azanul
requested changes
Oct 5, 2023
| Provider: "AWS", | ||
| Account: client.Name, | ||
| Service: "EventSourceMapping", | ||
| ResourceId: *mapping.UUID, |
There was a problem hiding this comment.
I think we can keep the anr field here instead of UUID, we do that most of the places
There was a problem hiding this comment.
Afaik, eventsourcemapping doesn't really have an arn, it has a UUID. That's because it's essentially an intermediary between the source (eg. SQS or Kinesis) and the lambda function. I can access the source ARN and lambda ARN though.
I've checked the above in the go sdk docs as well, if you find something different let me know and I'll make those changes.
Azanul
requested changes
Oct 5, 2023
Azanul
approved these changes
Oct 5, 2023
mlabouardy
approved these changes
Oct 5, 2023
roblambell
added a commit
to roblambell/komiser
that referenced
this pull request
Jan 8, 2024
list event source mappings has been needed since tailwarden#1040
4 tasks
Azanul
pushed a commit
that referenced
this pull request
Jan 9, 2024
* feat: add missing dynamodb action to policy.json describe table has been needed since #1111 * feat: add missing lambda action to policy.json list event source mappings has been needed since #1040 * feat: add missing iam action to policy.json list users has been needed since #991 * fix: correct s3 permission for list buckets api call listbucket iam action is for the contents of a bucket * feat: add missing code suite actions to policy.json needed since #1216, #1229, and #1228
Azanul
pushed a commit
that referenced
this pull request
Jan 9, 2024
* feat: add missing dynamodb action to policy.json describe table has been needed since #1111 * feat: add missing lambda action to policy.json list event source mappings has been needed since #1040 * feat: add missing iam action to policy.json list users has been needed since #991 * fix: correct s3 permission for list buckets api call listbucket iam action is for the contents of a bucket * feat: add missing code suite actions to policy.json needed since #1216, #1229, and #1228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Collector for Lambda collector not present
Solution
Add collector for AWS Lambda EventSourceMapping
Changes Made
EventSourceMappingsinproviders/aws/lambdalistOfSupportedServicesinproviders/aws/How to Test
In your AWS account, create a lambda function that has an SQS queue set as a trigger. With Komiser properly
configured to your account, you should see a
EventSourceMappingresource appear.Screenshots
Notes
Checklist
Reviewers