[Feat-1097] Add Avatar component, Optimize, Refactor and Improvements #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umrkhn
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
This was referenced Oct 22, 2023
Closed
Traxmaxx
suggested changes
Oct 23, 2023
dashboard/components/cloud-account/components/CloudAccountsLayout.tsx
Outdated
Show resolved
Hide resolved
|
Hei @umrkhn! Thanks a lot for the thorough PR and also for adding a Storybook entry! 🚀 Ping me if you have any questions : ) |
Kolawole99
suggested changes
Oct 24, 2023
|
@umrkhn were you able to address the requested changes? :) |
|
@mlabouardy I am waiting for @Traxmaxx 's response on the discussion for |
umrkhn
commented
Oct 31, 2023
|
@Traxmaxx @mlabouardy PR is ready for review. |
Traxmaxx
approved these changes
Nov 1, 2023
|
@umrkhn LGTM! Thanks so much for taking care of it 💚 I might have created a conflict yesterday by adding a new Civo SVG. Ping me if you have any questions! When the conflicts are resolved it's good to go. |
Traxmaxx
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1097
Problem
Avatarcomponent and a lot of duplicated code.providershelper object indashboard/utils/providerHelper.tscan be improved.Changes Made
Avatarcomponent with story and refactored all instances.providers=>platformapi indashboard/utils/providerHelper.tsmaking it easily extensible when adding new logos of different types also refactored all instances./explorer page.Notes
The changes and new integrations were tested thoroughly making sure the app doesnt break and work as expected.
Checklist