Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Services are Labeled with wrong Region #1128

Conversation

jolo-dev
Copy link
Contributor

@jolo-dev jolo-dev commented Oct 22, 2023

Fix for #1122.

Problem

The AWS Services were not mapped correctly because the concurrent function

wp.SubmitTask(func() {
does not work es expected.

Solution

Split the goroutine (there are now two) and add a shadow copy. This ensures that each goroutine has its own copy of the client and doesn't interfere with each other. (Little Bonus: it is much faster now)

Changes Made

  • providers/aws/aws.go

How to Test

Prerequisite: AWS should be setup.

Just run go run main.go start.

Screenshots

The wrong Output

komiser-resources-wrong

The expected Number

komiser-resources-fix

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@jolo-dev jolo-dev closed this Oct 23, 2023
@jolo-dev jolo-dev deleted the fix/1122-aws-services-are-labeled-with-wrong-region branch October 23, 2023 15:28
@jolo-dev
Copy link
Contributor Author

Not needed, as it was merged and fixed in another #1129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant