AWS Services are Labeled with wrong Region #1128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1122.
Problem
The AWS Services were not mapped correctly because the concurrent function
komiser/providers/aws/aws.go
Line 112 in 793bc3c
Solution
Split the goroutine (there are now two) and add a shadow copy. This ensures that each goroutine has its own copy of the client and doesn't interfere with each other. (Little Bonus: it is much faster now)
Changes Made
providers/aws/aws.go
How to Test
Prerequisite: AWS should be setup.
Just run
go run main.go start
.Screenshots
The wrong Output
The expected Number
Reviewers
@[username of the reviewer]