feat: Add Cost Calculation for DigitalOcean Volumes #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
bishal7679
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
Azanul
reviewed
Nov 13, 2023
| @@ -13,6 +13,9 @@ import ( | |||
| "github.com/tailwarden/komiser/providers" | |||
| ) | |||
|
|
|||
| var hourlyPrice float64 | |||
| const createdLayout = "2006-01-02T15:04:05Z" // 2020-07-21T18:37:44Z | |||
Azanul
requested changes
Nov 13, 2023
| @@ -13,6 +13,9 @@ import ( | |||
| "github.com/tailwarden/komiser/providers" | |||
| ) | |||
|
|
|||
| var hourlyPrice float64 | |||
There was a problem hiding this comment.
Please shift this var definition inside func
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
bishal7679
force-pushed
the
feature/add-cost-digitalocean-volume
branch
from
62ddcb4 to
1714ad4
Compare
Azanul
approved these changes
Nov 13, 2023
| func Volumes(ctx context.Context, client providers.ProviderClient) ([]models.Resource, error) { | ||
| var hourlyPrice float64 |
There was a problem hiding this comment.
nit: I meant a little closer to it's usage 😆
Signed-off-by: bishal7679 <bishalhnj127@gmail.com>
bishal7679
force-pushed
the
feature/add-cost-digitalocean-volume
branch
from
edd7a8a to
674789e
Compare
Co-authored-by: Azanul Haque <42029519+Azanul@users.noreply.github.com>
mlabouardy
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem #1048
Currently, cost calculation for DigitalOcean volumes is not implemented!
Solution
This PR is fixing tiny issue by adding cost calculation support for volumes of digitalocean
Changes Made
Checklist