Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version metadata to RDS resource #1305

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

alileza
Copy link
Contributor

@alileza alileza commented Dec 29, 2023

Problem

It's a nice to have for visibility to have the version collected as well, we currently have our own tool, but might deprecate that if we can use komiser fully, or maybe fork of it 🙏🏻

Solution

Just append the data to metadata for now, I guess there'll be UI change to show metadata in the UI

Changes Made

  • backend to store engine type & version in metadata
  • dashboard to show metadata

How to Test

[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]

Screenshots

Screenshot 2023-12-29 at 02 44 11

tested locally, get that info on metadata on the db

dashboard

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllieMendes @jakepage91 Please check this out

@jakepage91
Copy link
Contributor

This looks great to me, @AllieMendes would you have any formatting concerns?
@alileza really appreciate this!

@alileza
Copy link
Contributor Author

alileza commented Jan 3, 2024

@jakepage91 no worries, happy to find this project, I built something similar for inventory management internally, and komiser kinda almost doing everything I need, I just need a few more features to be added and might replace it with it.

I'm thinking there should be a feature where we can customize the main table column, on which information we'd like to show. I guess that's worth an issue or another PR.

In regards of the formatting I did try to figure out what would be better formatting there, but I'm not a frontend witch 🙏🏻

@jakepage91
Copy link
Contributor

Totally understand! No worries, our designer is out today but hopefully she can give up some feedback soon.
So cool that you already created a similar product. And I'm really happy that Komiser might be able to help you with a few extra features. To be honest I found love to jump on a call with you and talk about this a little bit more in depth to see exactly how we can get Komiser to be as useful as possible for you. Let me know if that works for you, you can book a time here. https://calendly.com/jake-tailwarden/30min

@AllieMendes
Copy link

Thank you for the proposal @alileza!
I don't have any feedback on the format, looks good to me @jakepage91

@mlabouardy mlabouardy merged commit 19eaeae into tailwarden:develop Jan 4, 2024
3 checks passed
@alileza alileza deleted the add-metadata branch January 5, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants