-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version metadata to RDS resource #1305
Conversation
c617d42
to
130e0a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllieMendes @jakepage91 Please check this out
This looks great to me, @AllieMendes would you have any formatting concerns? |
@jakepage91 no worries, happy to find this project, I built something similar for inventory management internally, and komiser kinda almost doing everything I need, I just need a few more features to be added and might replace it with it. I'm thinking there should be a feature where we can customize the main table column, on which information we'd like to show. I guess that's worth an issue or another PR. In regards of the formatting I did try to figure out what would be better formatting there, but I'm not a frontend witch 🙏🏻 |
Totally understand! No worries, our designer is out today but hopefully she can give up some feedback soon. |
Thank you for the proposal @alileza! |
Problem
It's a nice to have for visibility to have the version collected as well, we currently have our own tool, but might deprecate that if we can use komiser fully, or maybe fork of it 🙏🏻
Solution
Just append the data to metadata for now, I guess there'll be UI change to show metadata in the UI
Changes Made
How to Test
[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]
Screenshots
tested locally, get that info on metadata on the db
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@[username of the reviewer]