feat: added db utils to account and alert #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvineshTripathi
requested review from
mlabouardy,
greghub and
Azanul
as code owners
Azanul
reviewed
Apr 22, 2024
models/execution.go
Outdated
Comment on lines
20
to
23
| type DbHandler struct { | ||
| Db *bun.DB | ||
| } |
There was a problem hiding this comment.
I am thinking of moving the handler.db out of handler so apis should not be directly talking to the db. Do let me know if this is correct
There was a problem hiding this comment.
I think you're aiming for this kind of design (handler, controller, repository) but that's out of the scope of this PR. You may introduce the controller and repository layer in a different PR where we'd move the controller and DB logic out of handlers.
AvineshTripathi
force-pushed
the
db-utils
branch
from
7cf1348 to
98c966e
Compare
AvineshTripathi
changed the title
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Azanul
approved these changes
May 2, 2024
mlabouardy
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
[Provide a brief description of the problem that you are trying to solve with this pull request.]
Solution
[Provide a detailed explanation of the solution you are proposing, including any relevant code snippets or screenshots.]
Changes Made
How to Test
[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]
Screenshots
[Include screenshots, if relevant, to help reviewers understand the changes you made.]
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@[username of the reviewer]