Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added utils for filter #1421

Merged
merged 14 commits into from
Jun 11, 2024
Merged

Conversation

AvineshTripathi
Copy link
Collaborator

@AvineshTripathi AvineshTripathi commented May 14, 2024

No description provided.

@AvineshTripathi AvineshTripathi marked this pull request as ready for review May 19, 2024 11:02
Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The queries are predefined, we don't want to update any, rendering the lock & UpdateQuery needless.
  2. resourceCountOutput & regionCountOuput are same, can define a common one

Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still se the UpdateQuery function and related mutex

Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM

controller/resources.go Outdated Show resolved Hide resolved
@Azanul
Copy link
Collaborator

Azanul commented May 23, 2024

@AvineshTripathi CI filing

@Azanul Azanul merged commit 635f03b into tailwarden:develop Jun 11, 2024
3 checks passed
@AvineshTripathi AvineshTripathi deleted the filter-query branch August 31, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants