create local network gateway resource #1457
Conversation
azgcloudev
requested review from
mlabouardy,
AvineshTripathi,
greghub and
Azanul
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey, thank you for opening your Pull Request ! 🙂 While a Tailwarden team member takes a look at your PR we would like to invite you to join our official Discord server, where you can interact directly with other contributors and Tailwarden team members. Link here: https://discord.tailwarden.com
|
|
||
| for _, resourceGroup := range page.ResourceGroupListResult.Value { | ||
|
|
||
| resourceGroupNames = append(resourceGroupNames, *resourceGroup.Name) |
There was a problem hiding this comment.
can you also add other details like https://github.com/tailwarden/komiser/pull/1457/files#diff-e34e11157def2d0cf86866b6de46e377bda2def7d4aa338041dac225c5a1e7cfR56
There was a problem hiding this comment.
I made the change to add the resource as a model and not the string and fill the details.
However I do not added to to listOfSupportedServices as a resource group is not a provider.
| Name: *lng.Name, | ||
| FetchedAt: time.Now(), | ||
| Tags: tags, | ||
| Link: fmt.Sprint("https://portal.azure.com/#resource%s", *lng.ID), |
There was a problem hiding this comment.
can we fix the failure?
dashboard/utils/serviceHelper.ts
Outdated
| @@ -87,7 +87,8 @@ export const allProvidersServices: { [key in Providers]: string[] } = { | |||
| 'firewall', | |||
| 'load balancer', | |||
| 'databox', | |||
| 'queue' | |||
| 'queue', | |||
| 'Local Network Gateway' | |||
Problem
Solving Issue #396
Solution
Adding resource
Changes Made
added local network gateway
also created a function to get the resource groups in the subscription to be able to call all the local network gateways, as function do not call under a subscription level
How to Test
Added a new local network gateway in the Azure subscription, test if it shows successfully in Komiser. Cost is not showing, as LNGs do not generate cost.
Screenshots
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@jakepage91