feature: refactor and add banner to storybook #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knav33n
requested review from
mlabouardy,
AvineshTripathi,
greghub and
Azanul
as code owners
| @@ -35,7 +35,7 @@ function useGithubStarBanner() { | |||
| useEffect(() => { | |||
| const shouldDisplayBanner = checkLocalStorageForBannerStatus(); | |||
|
|
|||
| if (shouldDisplayBanner !== 'false' && router.query.view) { | |||
| if (true) { | |||
There was a problem hiding this comment.
why are we making this true?
There was a problem hiding this comment.
My apologies – I used this for some last-minute testing.
There was a problem hiding this comment.
LGTM
@Azanul please review the frontend changes! I saw the working and overview looks good to me
Azanul
approved these changes
Jul 24, 2024
|
@AvineshTripathi Please approve the PR if everything looks |
AvineshTripathi
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
1243
Changes Made
Screenshots
Checklist
Reviewers
@Traxmaxx @Azanul @AllieMendes @mlabouardy