Alter log level for disabled services #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Azanul
requested review from
mlabouardy,
AvineshTripathi and
greghub
as code owners
| @@ -34,12 +35,12 @@ RegionsLoop: | |||
| "projects/" + client.GCPClient.Credentials.ProjectID + "/locations/" + regionName, | |||
| ).Do() | |||
| if err != nil { | |||
| if err.Error() == "googleapi: Error 403: Location "+regionName+" is not found or access is unauthorized., forbidden" { | |||
| if err.Error() == "googleapi: Error 403: Location "+regionName+" is not found or access is unauthorized., forbidden" || strings.Contains(err.Error(), "SERVICE_DISABLED") { | |||
There was a problem hiding this comment.
is this resource specific or general 403 for all the services
There was a problem hiding this comment.
I'm not sure, it was there already so I didn't change it
Good suggestion! I thought so too but currently we have only one such error. Will implement it once we have more |
AvineshTripathi
approved these changes
Jul 31, 2024
This service disabled errors are not actual errors was pointed out by a user. If you have knowledge of such cases for any providers please feel free to create respective issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #1418
Solution
Fixes #1418
Changes Made
Checklist