feat: Added delete button to delete the unwanted objects from the timeline#2
Open
Pratiyankkumar wants to merge 1 commit intotailwiinder:mainfrom
Open
feat: Added delete button to delete the unwanted objects from the timeline#2Pratiyankkumar wants to merge 1 commit intotailwiinder:mainfrom
Pratiyankkumar wants to merge 1 commit intotailwiinder:mainfrom
Conversation
Author
|
@tailwiinder please take a look at this |
Owner
|
What a legend Let me review and get back (or merge if all's good) soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1
Added a delete button in the timeline to each object that is created so that it can be easily removed
Here is the video showing the changes made : https://drive.google.com/file/d/1GEbCFYdlZ4TdA7jBo90eYNpjq3E39FXC/view?usp=sharing
Also I made a small change in
manim_interface.pyto usesys.executableinstead of"python"to ensure Manim runs with the same interpreter as the current virtual environment, avoiding version or dependency mismatches.