React Combobox v2 type definitions don't support "by" prop in uncontrolled usage

[silvenon]

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

v2.2.0

What browser are you using?

N/A

Reproduction URL

https://stackblitz.com/edit/vitejs-vite-7mbtsold?file=src%2FApp.tsx

Describe your issue

In the Combobox React component the by prop is only permitted by TypeScript definitions if value is also provided, which doesn't allow for the uncontrolled usage. This was possible in v1, I'm not sure if by mistake or not.

Considering that onChange is a prop that will be most likely used on Combobox, how about removing NoInfer from the argument of that function?

[RobinMalfait]

Hey!

The by prop is supported, but as you mentioned the problem is that we infer the keys we can use inside of the by prop based on the value prop. But since there is no value we can't infer anything.

We wanted the value prop to be the source of truth to make things less confusing if the type is inferred by multiple props and combined, but obviously if there is no value then... yeah broken. You could work around it by being explicit and providing the type to the Combobox directly:

However, you can type the Combobox explicitly:

- <Combobox
+ <Combobox<typeof people[number]>

All that said... this should be fixed by #3798, and will be available in the next release.

You can already try it using:

• npm install @headlessui/react@insiders.

[silvenon]

Thank you! ❤️