-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure correct order when conditionally rendering Menu.Item
, Listbox.Option
and RadioGroup.Option
#1045
Conversation
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/HvcgQJvLGg92e8qLXTZXh7jmrPtm headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/6MKNuTXU9MwtQkbbUCLA6ujr2vgi |
Menu.Item
Menu.Item
, Listbox.Option
and RadioGroup.Option
68506c8
to
b3f4196
Compare
b3f4196
to
eef7b13
Compare
I am seeing an out of order navigation on Combobox, would a similar fix help there as well? |
@cabello this should already be implemented, but make sure to use the insiders build for now: You can already try it using:
|
This PR will ensure that the order of
Menu.Item
,Listbox.Option
andRadioGroup.Option
is correct even if you re-rendered some items conditionally essentially re-ordering them.This is both applied to the React and Vue versions.
Fixes: #994