Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox improvements #1101

Merged
merged 7 commits into from
Feb 10, 2022
Merged

Combobox improvements #1101

merged 7 commits into from
Feb 10, 2022

Commits on Feb 9, 2022

  1. ensure combobox option gets activated on hover (while static)

    @RobinMalfait
    RobinMalfait committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    b75b57c View commit details
    Browse the repository at this point in the history

  2. rename combobox test file

    @RobinMalfait
    RobinMalfait committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    ade15c4 View commit details
    Browse the repository at this point in the history

  3. remove leftover horizontal prop

    @RobinMalfait
    RobinMalfait committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    71c5014 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary handleLeave calls 

    These are implemented on the `Combobox.Option` instead of the
`Combobox.Options`. This allows you to have additional visual padding
between `Combobox.Options` and `Combobox.Option` and if you hover over
that area then the option becomes inactive.

If we implement it on the `Combobox.Options` instead then this isn't
_that_ easy to do. We can do it by checking the target and whether or
not it is inside a headlessui-combobox-option. This would only have a
single listener instead of `N` listeners though. Potential improvements!
    @RobinMalfait
    RobinMalfait committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    919e0bc View commit details
    Browse the repository at this point in the history

  5. implement hold in favor of latestActiveOption

    @RobinMalfait
    RobinMalfait committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    cf02307 View commit details
    Browse the repository at this point in the history

  6. update changelog

    @RobinMalfait
    RobinMalfait committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    cdc6e5f View commit details
    Browse the repository at this point in the history

  7. Allow Escape to bubble when options is static 

    You’ve taken control of the open/close state yourself in which case this should be allowed to be handled by other event handlers
    @thecrypticace
    thecrypticace committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    fc3a175 View commit details
    Browse the repository at this point in the history