Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger scrollIntoView effect when position changes #1113

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Trigger scrollIntoView effect when position changes #1113

merged 2 commits into from
Feb 17, 2022

Commits on Feb 17, 2022

  1. trigger scrollIntoView effect when position changes 

    This is important otherwise it could happen that the current active item
is still the active item even if we inserted X items before the current
one. This will result in the active item being out of the current
viewport. To fix this, we will also make sure to trigger the effect if
the position of the active item changes.
    @RobinMalfait
    RobinMalfait committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    00903d5 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    3219f4c View commit details
    Browse the repository at this point in the history