Fix transition enter bug
#1519
Merged
Fix transition enter bug
#1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an issue where an open Dialog got hidden by css didn't properly unmount because the Transition never "finished". We fixed this by checking if the node was hidden by using `getBoundingClientRect`. Today I learned that just *reading* those values (aka call `node.getBoundingClientRect()`) it for whatever reason completely stops the transition. This causes the enter transitions to completely stop working. Instead, we move this code so that we only check the existence of the Node when we try to transition out because this means that the Node is definitely there, just have to check its bounding rect.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
added a commit
that referenced
this pull request
Jul 8, 2024
This was originally introduced in #1519 to fix an issue where some enter transitions where broken: #1503 However, since we refactored the `Transition` component to make use of the `useTransition` hook, I can't seem to reproduce this issue anymore. In fact, removing this code fixes an issue. The bigger issue here is that when the component becomes hidden, that we always set the state to hidden as well. But if it becomes visible again, we don't show it again. Right now, since I couldn't reproduce any of the other issue, I opted to just removing the code entirely. But if we ever need it again, we probably have to make sure that it becomes visible in the other scenario as well. Fixes: #3328
RobinMalfait
added a commit
that referenced
this pull request
Jul 10, 2024
…dden (#3372) * do not change visibility of `Transition` component This was originally introduced in #1519 to fix an issue where some enter transitions where broken: #1503 However, since we refactored the `Transition` component to make use of the `useTransition` hook, I can't seem to reproduce this issue anymore. In fact, removing this code fixes an issue. The bigger issue here is that when the component becomes hidden, that we always set the state to hidden as well. But if it becomes visible again, we don't show it again. Right now, since I couldn't reproduce any of the other issue, I opted to just removing the code entirely. But if we ever need it again, we probably have to make sure that it becomes visible in the other scenario as well. Fixes: #3328 * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where an open Dialog got hidden by css didn't properly unmount because the Transition never "finished". We fixed this by checking if the node was hidden by using
getBoundingClientRect.Today I learned that just reading those values (aka call
node.getBoundingClientRect()) it for whatever reason completely stops the transition. This causes the enter transitions to completely stop working.Instead, we move this code so that we only check the existence of the Node when we try to transition out because this means that the Node is definitely there, just have to check its bounding rect.
Fixes: #1503