Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling issue in Tab component when using arrow keys #1584

Merged
merged 4 commits into from
Jun 13, 2022

Conversation

RobinMalfait
Copy link
Member

This PR fixes an issue where using your arrow keys on the Tab component could scroll the page, this
is obviously not something that we want.

event.preventDefault() to the rescue!

@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 11:25AM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 11:25AM (UTC)

@RobinMalfait RobinMalfait changed the title Fix scrolling issue in Tab component when using arrow keys Fix scrolling issue in Tab component when using arrow keys Jun 13, 2022
Does GitHub Actions have an incorrect cache somehow?
@RobinMalfait
Copy link
Member Author

GitHub Actions seems down: https://twitter.com/githubstatus/status/1536309628656570368

@RobinMalfait RobinMalfait merged commit ec84c72 into main Jun 13, 2022
@RobinMalfait RobinMalfait deleted the fix/tabs-vertical-scroll branch June 13, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant