Close Menu
component when using tab
key
#1673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an odd one, we always used to focus trap when the
Menu
component is open and I'mpretty sure this was also recommend on some pages.
Looking at the new ARIA Authoring Practices Guide (APG) pages this is now recommended https://www.w3.org/WAI/ARIA/apg/patterns/menu/
This is also what was mentioned by @eriese on the original issue #1634 and #1639
This PR is a continuation of #1639 with a few more improvements and cleanup, but I started from the
original PR just so that the original work from @eriese is includes (Thanks for starting this!)
I also did some digging around the internet and other libraries implement it either using focus
trapping or with the new proper "move focus out" code.
Closes: #1639
Fixes: #1634