Warn when changing Combobox between controlled and uncontrolled
#1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
requested changes
Sep 29, 2022
There was a problem hiding this comment.
Interesting, I think this might already behave as expected if you look at React itself 🤔
https://codesandbox.io/s/sleepy-snow-v4m8eu?file=/src/App.js
thecrypticace
changed the title
Combobox input when value is set to undefinedCombobox from controlled to/from uncontrolled
thecrypticace
changed the title
Combobox from controlled to/from uncontrolledCombobox between controlled and uncontrolled
thecrypticace
force-pushed
the
fix/combobox-resync-undefined
branch
from
b862fa5
to
6f3fd14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't handle changes to/from
undefined. However this is okay. If you specify a value ofundefinedyou're saying you want an uncontrolled component. This follows React's own conventions for inputs for example.We'll warn when changing between a controlled and uncontrolled component as this can be considered an implementation error.
Fixes #1177