Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the import * as React from 'react' pattern #2242

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Use the import * as React from 'react' pattern #2242

merged 2 commits into from
Feb 2, 2023

Commits on Feb 1, 2023

  1. use the import * as React from 'react' pattern 

    We use named imports, but we have to import `React` itself as well for
JSX because it compiles to `React.createElement`. We could get rid of
our own JSX and use it directly, or we can use this `import * as React
from 'react'` syntax.

This fixes an issue for people using `allowSyntheticDefaultImports: false` in TypeScript.

Fixes: #2117
    @RobinMalfait
    RobinMalfait committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1b3e60f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. update changelog

    @RobinMalfait
    RobinMalfait committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    5161a76 View commit details
    Browse the repository at this point in the history