Export component interfaces #2313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm facing the precise problem that this solves. Is there any movement here? |
|
Interested to see this change released as well |
|
This change would make building custom primitives really easy. Any estimation on when should we expect this to be merged? |
4 tasks
This is not ideal because we don't want these to be public. However, if you are creating components on top of Headless UI, the TypeScript compiler needs access to them. So now they are public in a sense, but you shouldn't be interacting with them directly. Co-authored-by: Jordan Pittman <jordan@cryptica.me>
RobinMalfait
force-pushed
the
fix/export-unnamed-types
branch
from
6b8ce44
to
cf0fa33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn’t really ideal. We’d rather not export these and instead export implicit function types but TypeScript doesn’t appear to be too happy about trying to do that.
This is a WIP. Would definitely prefer to find a different solution here if possible that fixes the problem but also doesn't increase the surface area of exported types.
Fixes #2306