Fix CJS types #2880
Merged
Fix CJS types #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2838
Comically enough our ESM types are correct for CJS as well because we don't use default nor do we need to use
export =in CJS. We only have named exports for Headless UI.This means that, in TypeScript, the
export function,export let, etc… syntax all works fine for CJS.Given that, there's a quick and dirty fix for this:
exportsto use point to these files separatelyIf we ever added a default export like
export defaultthen things would break but the Node 10 check would catch it. Likewise, if we ever didmodule.exports = …somewhere then the Node 16 check would catch that.