Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure panels re-register when IDs are calculated in React < 18 #2883

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Make sure panels re-register when IDs are calculated in React < 18 #2883

merged 3 commits into from
Apr 12, 2024

Conversation

thecrypticace
Copy link
Contributor

Fixes #2882

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ❌ Failed (Inspect) Apr 12, 2024 3:16pm
headlessui-vue ❌ Failed (Inspect) Apr 12, 2024 3:16pm

@camsloanftc
Copy link

Just wanted to confirm this is an issue we are experiencing on our team and was curious if this may go in soon. Thanks!

@RobinMalfait RobinMalfait changed the base branch from main to 1.x April 12, 2024 15:09
@RobinMalfait RobinMalfait force-pushed the fix/reregister-tab-panel-id branch from 9036455 to 6c259a1 Compare April 12, 2024 15:16
@RobinMalfait RobinMalfait merged commit 2b161b3 into 1.x Apr 12, 2024
6 of 8 checks passed
@RobinMalfait RobinMalfait deleted the fix/reregister-tab-panel-id branch April 12, 2024 15:19
@RobinMalfait RobinMalfait mentioned this pull request Apr 12, 2024
Closed
This was referenced May 18, 2024
Closed
Closed
Closed
@michael-moussaoui michael-moussaoui mentioned this pull request May 20, 2024
Open
This was referenced May 21, 2024
Closed
Closed
Closed
@ishaan-jaff ishaan-jaff mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Jeb4dev Jeb4dev mentioned this pull request May 25, 2024
Closed
@ha404 ha404 mentioned this pull request May 25, 2024
Open
This was referenced May 26, 2024
Closed
Closed
@JMARRUJO91 JMARRUJO91 mentioned this pull request May 27, 2024
Closed
@gr00nd gr00nd mentioned this pull request May 28, 2024
Open
@Jeb4dev Jeb4dev mentioned this pull request May 28, 2024
Closed
This was referenced May 28, 2024
Open
Open
@Jeb4dev Jeb4dev mentioned this pull request May 29, 2024
Closed
@JMARRUJO91 JMARRUJO91 mentioned this pull request May 29, 2024
Closed
@gr00nd gr00nd mentioned this pull request May 29, 2024
Open
@Jeb4dev Jeb4dev mentioned this pull request May 30, 2024
Closed
@JMARRUJO91 JMARRUJO91 mentioned this pull request May 30, 2024
Open
This was referenced May 31, 2024
Closed
Open
Open
@Artur-data-DEV Artur-data-DEV mentioned this pull request Jun 5, 2024
Open
@iamsatyanchal iamsatyanchal mentioned this pull request Jun 5, 2024
Open
@thierry-laval thierry-laval mentioned this pull request Jun 6, 2024
Open
@gr00nd gr00nd mentioned this pull request Jun 15, 2024
Open
This was referenced Jun 18, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabs Component Accessibility - aria-controls Value Issue in React 17
3 participants
@thecrypticace @camsloanftc @RobinMalfait