Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose disabled state on <Tab /> component #2918

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Jan 9, 2024

This PR fixes an issue where disabled on the <Tab/> component wasn't exposed.

This will expose it such that you can use it with ui-disabled. In the Alpha version of React, you can also use data-[disabled] because it will be exposed as data-disabled over there as well.

Marked it as fixed because we already accept the disabled state and expose it in some other components so considered it "missing".

Fixes: #2864

This will expose it such that you can use it with `ui-disabled`. In the
Alpha version of React, you can also use `data-[disabled]` because it
will be exposed as `data-disabled` over there as well.

Fixes: #2864
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 2:42pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 2:42pm

@RobinMalfait RobinMalfait merged commit 2b7a57e into main Jan 9, 2024
8 checks passed
@RobinMalfait RobinMalfait deleted the fix/issue-2864 branch January 9, 2024 14:45
RobinMalfait added a commit that referenced this pull request Apr 15, 2024
* expose `disabled` on `<Tab/>` component

This will expose it such that you can use it with `ui-disabled`. In the
Alpha version of React, you can also use `data-[disabled]` because it
will be exposed as `data-disabled` over there as well.

Fixes: #2864

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui-disabled doesn't work for Tabs
1 participant