Change default tags for ListboxOptions, ListboxOption, ComboboxOptions, ComboboxOption and TabGroup components
#3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
change/default-tags
branch
from
df4d530
to
26fe8da
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
change/default-tags
branch
from
00326f2
to
26fe8da
Compare
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default tags for the following components:
divas default tag forListboxOptionsandListboxOptioncomponentsdivas default tag forComboboxOptionsandComboboxOptioncomponentsThese were using
ulandlirespectively, which means that if you usedas="div"on one of them, that you would have to useas="div"on the other but that's not always clear and nothing will break or throw an error if you do. It would just be incorrect HTML.We already set a custom
roleattribute, so the default role we get fromul/lielements was overwritten anyway.divas default tag forTabGroupIn a lot of places an additional wrapper element OR
as="div"was requirement for layout such as constraining the width. Making theTabGroupasdivby default will make it easier to do that.These are better defaults for these components for Headless UI v2.