Ensure the static and portal props work nicely together
#3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
around anchored elements.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
reinink
approved these changes
Apr 29, 2024
thecrypticace
approved these changes
Apr 29, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
staticprop and theportalprop (oranchorprop which enables theportalprop by default) didn't work well together. This is because the wrapping<Portal />component was not taking thestaticprop into account.This is needed when you want to use the
portaland/oranchorprop in combination with a 3rd party animation library (such asframer-motion) where thestaticprop is needed.