Don’t cancel touchmove on input elements inside a dialog
#3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thecrypticace
force-pushed
the
fix/touchmove-drag-issues
branch
from
1d70b59 to
7130b90
Compare
|
This is the most impressive response time, I've ever seen to my issue reports. Big kudos, much appreciated, can't wait for this to land 🙏 Thanks! |
RobinMalfait
reviewed
May 3, 2024
packages/@headlessui-react/src/hooks/document-overflow/handle-ios-locking.ts
Outdated
Show resolved
Hide resolved
thecrypticace
force-pushed
the
fix/touchmove-drag-issues
branch
from
a27011b to
e13ba0c
Compare
RobinMalfait
approved these changes
May 3, 2024
thecrypticace
added a commit
that referenced
this pull request
May 3, 2024
* Don’t cancel touchmove on `input` elements inside a dialog * Update changelog * Update # Conflicts: # packages/@headlessui-react/CHANGELOG.md
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prevent the default
touchmoveevent on some elements inside a dialog on iOS as it is the only reliable way to prevent scrolling asoverflow: hiddenitself is not enough in some cases.We shouldn't do this for
inputelements because cancelling the event for<input type="range">prevents the user from interacting with it at all. This PR checks for input elements and bails.Fixes #3165