Fix incorrect Transition boundary for Dialog component
#3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially we didn't do this, because it's a bit silly to do that if you
already had a `Transition` component on the outside. E.g.:
```tsx
<Transition show={open}>
<Dialog onClose={() => setOpen(false)}>
{/* ... */}
</Dialog>
</Transition>
```
Because this means that we technically have this:
```tsx
<Transition show={open}>
<Dialog onClose={() => setOpen(false)}>
<Transition>
<InternalDialog>
{/* ... */}
</InternalDialog>
</Dialog>
</Transition>
</Transition>
```
The good part is that the inner `Transition` is rendering a `Fragment`
and forwards all the props to the underlying element (the internal
dialog).
This way we have a guaranteed transition boundary.
This also mimics better what we are actually trying to do.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
commented
Jun 26, 2024
Comment on lines
-393
to
-394
| let inTransitionComponent = usesOpenClosedState !== null | ||
| if (!inTransitionComponent && open !== undefined && !rest.static) { |
There was a problem hiding this comment.
Now we are not relying on the OpenClosed state from a parent to know whether we should wrap the Dialog in a Transition
Instead, we will always do that. If you happen to already wrap your Dialog in a Transition on the outside, then the props will be forwarded to the underlying element because Transition renders as Fragment by default.
thecrypticace
approved these changes
Jun 26, 2024
This was referenced Jun 26, 2024
This was referenced Jul 27, 2024
This was referenced Aug 15, 2024
This was referenced Aug 29, 2024
This was referenced Sep 6, 2024
This was referenced Sep 10, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that each
Dialogis always a newTransitionboundary such that nestedTransitionChildcomponents are correctly handled.If you happen to nest
Dialogcomponents in places where you shouldn't (e.g.: inside aDisclosureinstead of aDisclosurePanel) then it could lead to a crash that has been fixed by this change.Fixes: #3316
Fixes: #3322