Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging tests when using anchor prop #3357

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Fix hanging tests when using anchor prop #3357

merged 6 commits into from
Jul 3, 2024

Commits on Jul 3, 2024

  1. add test that verifies unit test hang

    @RobinMalfait
    RobinMalfait committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    70b6f99 View commit details
    Browse the repository at this point in the history

  2. bail when parsing the maxHeight results in NaN

    @RobinMalfait
    RobinMalfait committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3d09fdc View commit details
    Browse the repository at this point in the history

  3. playground cleanup 

    Testing using this playground example, so cleaned it up to be more
modern using newer components, transition prop and so on.
    @RobinMalfait
    RobinMalfait committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    dacb822 View commit details
    Browse the repository at this point in the history

  4. use CSS instead of JS 

    Let's make it a CSS problem instead of a JS problem. The
`round(up, <valueToRound>, <roundingInterval>)` will behave similar to a
`Math.ceil()` that we had in the JS implementation.

See: https://developer.mozilla.org/en-US/docs/Web/CSS/round
    @RobinMalfait
    RobinMalfait committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8a19113 View commit details
    Browse the repository at this point in the history

  5. Remove CSS solution for now 

    I want to re-enable this in the future, but unfortunately for now we
can't use it because Chrome only introduced support for this in the last
2 months.

This reverts commit daac60d45ec3f02b324d0d8b18078a995e885733.
    @RobinMalfait
    RobinMalfait committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8ef4d64 View commit details
    Browse the repository at this point in the history

  6. update changelog

    @RobinMalfait
    RobinMalfait committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ce412c5 View commit details
    Browse the repository at this point in the history