Add client hint to close provider #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamwathan
reviewed
Aug 19, 2024
philipp-spiess
force-pushed
the
fix/close-provider-client-hint
branch
from
d089d33 to
7b4bd42
Compare
thecrypticace
approved these changes
Aug 19, 2024
This was referenced Sep 18, 2024
Closed
This was referenced Sep 23, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing client boundary in the close provider file that was causing crashes when used with Turbopack as reported in the Next.js repo: vercel/next.js#68205
Test plan
Thanks to @richardasymmetric fantastic repro I could check out the example repo and link a tarball build of the updated
@headlessui/reactpackage to validate that this is enough to resolve the issue. After this change,next devandnext dev --turbowork in the same way.