-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent crash in environments where Element.prototype.getAnimations
is not available
#3473
Merged
+66
−51
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aa6cff1
add minimal polyfill for `Element.prototype.getAnimations`
RobinMalfait 0e8a1a7
use `jsdom-testing-mocks`
RobinMalfait 9441db0
update changelog
RobinMalfait 1ad0dbd
use optional chaining
RobinMalfait 7d8a040
update warning message slightly
RobinMalfait 5aec94f
drop the `from`, it's cleaner
RobinMalfait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1 @@ | ||
globalThis.IS_REACT_ACT_ENVIRONMENT = true | ||
|
||
// These are not 1:1 perfect polyfills, but they implement the parts we need for | ||
// testing. The implementation of the `getAnimations` uses the `setTimeout` | ||
// approach we used in the past. | ||
// | ||
// This is only necessary because JSDOM does not implement `getAnimations` or | ||
// `CSSTransition` yet. This is a temporary solution until JSDOM implements | ||
// these features. Or, until we use proper browser tests using Puppeteer or | ||
// Playwright. | ||
{ | ||
if (typeof CSSTransition === 'undefined') { | ||
globalThis.CSSTransition = class CSSTransition { | ||
constructor(duration) { | ||
this.duration = duration | ||
} | ||
|
||
finished = new Promise((resolve) => { | ||
setTimeout(resolve, this.duration) | ||
}) | ||
} | ||
} | ||
|
||
if (typeof Element.prototype.getAnimations !== 'function') { | ||
Element.prototype.getAnimations = function () { | ||
let { transitionDuration, transitionDelay } = getComputedStyle(this) | ||
|
||
let [durationMs, delayMs] = [transitionDuration, transitionDelay].map((value) => { | ||
let [resolvedValue = 0] = value | ||
.split(',') | ||
// Remove falsy we can't work with | ||
.filter(Boolean) | ||
// Values are returned as `0.3s` or `75ms` | ||
.map((v) => (v.includes('ms') ? parseFloat(v) : parseFloat(v) * 1000)) | ||
.sort((a, z) => z - a) | ||
|
||
return resolvedValue | ||
}) | ||
|
||
let totalDuration = durationMs + delayMs | ||
if (totalDuration === 0) return [] | ||
|
||
return [new CSSTransition(totalDuration)] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also check for
typeof process.env !== 'undefined'
or make theprocess.env[]
lookup an optional chain, just to prevent a crash in some very weird setups:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not a bad idea honestly