Add missing NODE_ENV checks to ComboBox
#3487
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
) This PR is a different approach compared to #3487. Instead of checking whether we are in a test environment (specifically in a Jest environment), I think we can just get rid of the check entirely and use the virtualizer in all environments. This will remove an unnecessary check for `process` being available and gets rid of `process` entirely. It also fixes an issue that #3487 tries to solve where `process` is available, but `process.env` is not. Closes: #3487
|
Hey! Thank you for the PR, I did implement an alternative by getting rid of the Either way, we got rid of the entire check in #3495 and will be available in the next release. You can already try it using:
Thanks again for your initial work! |
|
Hi, I encountered this issue when I was running the Cypress component tests. The environment was Typescript + Cypress + React + Vite. For some reason Cypress exposes an empty I ran my tests with |
|
@panusoi Aha good to know, thanks for the info. Glad it's working with the insiders build! |
This PR fixes an issue where a virtualized
ComboBoxcrashed if there was globalprocessvariable withoutenvproperty. The issue was caused by a missingprocess.env.NODE_ENV === 'test'check which caused the branch to end up in the released version.