Ensure outside click properly works when clicking SVG elements #3777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: tailwindlabs#3752 Reuses code from: tailwindlabs#3704 Right now `touchend` only checks if target is HTMLElement, but this check will fail for some other elements (like SVG elements). This change brings dom utils from tailwindlabs#3704 to Vue to properly resolve target.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
RobinMalfait
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3752
Reuses code from: #3704
Right now
touchendonly checks if target is HTMLElement, but this check will fail for some other elements (like SVG elements).This change brings dom utils from #3704 to Vue to properly resolve target.
Before:
Screen.Recording.2025-08-25.at.16.28.48.mov
After:
Screen.Recording.2025-08-25.at.16.28.15.mov