Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support tree-shaking by enabling preserveModules
In order to enable tree-shaking, we need to specify
sideEffects: true
,unfortunately, after experiments, it turned out not to be enough and I had to enable
preserveModules
, which webpack seems to be able to use to properly remove unused code, that part was Inspired by jaredpalmer/tsdx#276I first noticed that headless-ui is not being tree-shaked in lighthouse:
After adding the changes in this PR the packages is no longer showing up as unused:
I also ran @next/bundle-analyzer
Before:
After:
Also, before / after results from Chrome: