Provide event to Dialog onClose callback.
#768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give Dialog consumers additional context when deciding whether to prevent closing the dialog. An example for where this is useful is when an action is triggered from a dialog that results in a transient notification (e.g., a snackbar) that includes dismiss and/or action buttons. Clicking on a button inside the notification should not close the dialog, even if the notification itself is not a child of the dialog in the DOM.
|
@ChadBurggraf is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Please let me know if you'd prefer that I open this against |
|
@RobinMalfait Hi! Any way we can get this merged? Would be really helpful. Thank you! |
|
Hey! Thank you for your PR! The issue you are describing should already be fixed so going to close this for now. Thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give Dialog consumers additional context
when deciding whether to prevent closing the dialog.
An example for where this is useful is when an action is
triggered from a dialog that results in a transient notification
(e.g., a snackbar) that includes dismiss and/or action buttons.
Clicking on a button inside the notification should not close the
dialog, even if the notification itself is not a child of the
dialog in the DOM.
This also makes scenarios like #621 easier.