Ensure interactability with Popover.Panel contents in static mode #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/6ZH9iV9RYkCGd34YEbUhMaApG8u1 headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/8rQia3JBQX2WoihEbkPMxkHC6tk1 |
RobinMalfait
changed the title
RobinMalfait
force-pushed
the
merge-event-listeners
branch
from
bc540da
to
7e461af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "click outside" logic was broken for the
Popover.Panelif you used thestaticmode.This is because the
staticmode is used for always rendering thePopover.Panel, even if thePopoveritself is not open anymore. This results in a bug that would close thePopover.Panelcomponent itself if thePopoverstate wasClosed(by setting the panel ref tonull). But this shouldn't happen since we are usingstaticto keep it open.Closes: #283