feat(react): Allow Tab Component to be controlled #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChiefORZ is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi, @RobinMalfait, thanks for your work on headless ui. Any chance this pr will get merged? |
|
@ChiefORZ Do you have any workaround for this issue? |
|
@trankhacvy we copied the whole component into our project |
|
Would love to see this merged. @RobinMalfait |
|
Hey! Thank you for your PR! This was merged in #970 and will get a new version out asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to controll the selected tab from the outside.
Here is a example: https://codesandbox.io/s/headlessui-tab-uncontrolled-m2v5p
With this change, we can pass a
selectedIndexto the Tab.Group Component.