Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure portal root exists in the DOM #950

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Ensure portal root exists in the DOM #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fd2c56
ensure that the portal root is always in the DOM
RobinMalfait Nov 23, 2021
5d4cd04
update changelog
RobinMalfait Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased - React]

- Nothing yet!
### Fixes

- Ensure portal root exists in the DOM ([#950](https://github.com/tailwindlabs/headlessui/pull/950))

## [Unreleased - Vue]

Expand Down
9 changes: 9 additions & 0 deletions packages/@headlessui-react/src/components/portal/portal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@ function usePortalTarget(): HTMLElement | null {
return document.body.appendChild(root)
})

// Ensure the portal root is always in the DOM
useEffect(() => {
if (target === null) return

if (!document.body.contains(target)) {
document.body.appendChild(target)
}
}, [target])

useEffect(() => {
if (forceInRoot) return
if (groupTarget === null) return
Expand Down