Fix clicks in portals in React dialog closing dialog #989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering portals inside a React Dialog (e.g. a dropdown using Popper.js), clicks inside that portal are detected as clicks outside die dialog and causing the dialog to be closed.
This PR is an attempt to fix that and treating elements inside portals as inside the dialog.
However, there are some problems which make me unsure whether this particular PR should really be merged:
onMouseDown
prop the dialog owns is probably a breaking change which makes this difficult to releaseLet me know whether you think it makes sense for me to continue working on this and address the issues above or whether we should just close this. 😊
Related: #432